← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~ted/indicator-appmenu/transient-windows into lp:indicator-appmenu

 

Review: Needs Information
I don't like that the 'while' may loop endlessly if there is an issue with the stack of parent and transient windows, especially for unsupported applications which will have no menus.
I would have expected the transient window to be the focused one, and the code to look for the /parent/ menu (ie bamf_get_parent?).

If bamf already takes care of mapping app windows and their transient windows, why is a traversal of the stack required?
-- 
https://code.launchpad.net/~ted/indicator-appmenu/transient-windows/+merge/27669
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.



Follow ups

References