← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~bratsche/appmenu-gtk/ubuntu-no-proxy-support into lp:appmenu-gtk

 

Review: Approve
Looks fine to me.

  review approve

On Wed, 2010-06-16 at 21:13 +0000, Cody Russell wrote:
> Cody Russell has proposed merging lp:~bratsche/appmenu-gtk/ubuntu-no-proxy-support into lp:appmenu-gtk.
> 
> Requested reviews:
>   Canonical Desktop Experience Team (canonical-dx-team)
> 
> differences between files attachment (review-diff.txt)
> === modified file 'src/bridge.c'
> --- src/bridge.c	2010-06-15 14:56:13 +0000
> +++ src/bridge.c	2010-06-16 21:13:25 +0000
> @@ -524,6 +524,19 @@
>  
>        return;
>      }
> +  else
> +    {
> +      gboolean no_proxy;
> +
> +      g_object_get (G_OBJECT (toplevel),
> +                    "ubuntu-no-proxy", &no_proxy,
> +                    NULL);
> +
> +      if (no_proxy)
> +        {
> +          return;
> +        }
> +    }
>  
>    if (!gtk_widget_get_realized (toplevel))
>      {
> 



-- 
https://code.launchpad.net/~bratsche/appmenu-gtk/ubuntu-no-proxy-support/+merge/27772
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.



References