ayatana-commits team mailing list archive

[David Barth <david.barth@xxxxxxxxxxxxx>]

Review: Approve
The framework part looks fine. The rest of the code (the big if/else statement changes) is difficult to follow and a good bugs nest imo. That would benefit from becoming small routines with a clearer purpose mapped to the different scenarios envisaged in the spec.

window_menus, i'd rename into default_menus to make it more obvious that's it's not any applications menu, but menus for the default case.

No obvious issue spotted for the code in general.

I think it's ok to put a /* FIXME: re-factor */ and land it: Friday is for QA/refactoring we'll say ;)
-- 
https://code.launchpad.net/~ted/indicator-appmenu/application-fallback/+merge/27794
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.