ayatana-commits team mailing list archive

Thread
Date

Re: [Merge] lp:~cjcurran/indicator-sound/mpris-backend into lp:indicator-sound

To: Conor Curran <conor.curran@xxxxxxxxxxxxx>
From: David Barth <david.barth@xxxxxxxxxxxxx>
Date: Thu, 17 Jun 2010 16:33:27 -0000
In-reply-to: <20100617154541.9050.64001.launchpad@loganberry.canonical.com>
Reply-to: mp+27847@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information
- on metadata-menu-item.vala/update: is the information guaranteed to be non null and "human readable" (like reading: "<unknown artist>") by the underlying backend (mpris) or is that something the UI should sanitize? worth mentioning in a comment or add a FIXME for QA day (Friday)
- + the leak neil mentionned
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/mpris-backend/+merge/27847
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

References

[Merge] lp:~cjcurran/indicator-sound/mpris-backend into lp:indicator-sound
From: Conor Curran, 2010-06-17