ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

On Fri, 2010-06-18 at 07:09 +0000, David Barth wrote:
> 2. If there is a bug to fix, is there a bug report? If there is 
> an error, is there a test case to show that this fixes the error?

Yes.  https://bugs.launchpad.net/indicator-application/+bug/594199

> 3. is the second g_return_if_fail checking for a legitimate development 
> error (http://library.gnome.org/devel/glib/stable/glib-Warnings-and-Assertions..html#glib-Warnings-and-Assertions.description) or shouldn't be an if (..) return?

Since it's a value passed from the same enum structure on the library to
the service -- I would seriously hope that it wouldn't fail a lookup.
Since it's dbus, I think changing it could make sense.  I think it still
needs to be a warning though.

Fixed r134.


-- 
https://code.launchpad.net/~ted/indicator-application/icon-switching/+merge/27901
Your team ayatana-commits is subscribed to branch lp:indicator-application.