ayatana-commits team mailing list archive

["Neil J. Patel" <neil.patel@xxxxxxxxxxxxx>]

Review: Needs Fixing
In addition to the comments about using the Value struct on IRC, 

- gchar* symbol = transport_widget_toggle_play_label(d.... need to g_free (symbol) afterwards?
- In signal callbacks like transport_widget_button_release_event, I'd suggest doing a g_return_if_fail (FOO_IS_BAR (data)); before accessing priv, as your not in control of what it returns (say, for instance, it's returning a pointer to an object that doesn't exist anymore, you don't want to segfault).

Apart from that, it's looking good.
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/refactoring_1/+merge/28156
Your team ayatana-commits is subscribed to branch lp:indicator-sound.