ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Review: Approve
So excited!

  review approve

On Mon, 2010-06-28 at 20:45 +0000, Cody Russell wrote:
> Cody Russell has proposed merging lp:~bratsche/appmenu-gtk/rebuild-on-attach into lp:appmenu-gtk.
> 
> Requested reviews:
>   Canonical Desktop Experience Team (canonical-dx-team)
> 
> 
> This will have no noticeable effect until my gtk+ patch gets merged into Ubuntu.  seb128 said he'll do that in the morning.
> 
> That gtk+ patch combined with this new revision will fix all remaining issues with missing menuitems and, I believe, with menuitems being out of order.
> differences between files attachment (review-diff.txt)
> === modified file 'src/bridge.c'
> --- src/bridge.c	2010-06-25 17:45:25 +0000
> +++ src/bridge.c	2010-06-28 20:45:43 +0000
> @@ -771,6 +771,12 @@
>                              bridge);
>            return;
>          }
> +      else
> +        {
> +          toplevel = gtk_widget_get_toplevel (attach);
> +
> +          rebuild_window_items (bridge, toplevel);
> +        }
>      }
>  
>    if (GTK_IS_WINDOW (toplevel))
> 



-- 
https://code.launchpad.net/~bratsche/appmenu-gtk/rebuild-on-attach/+merge/28681
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.