← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~cjcurran/indicator-sound/custom-transport into lp:indicator-sound

 

Review: Needs Fixing
This branch needs some fixes. Get rid of the unused prototypes...

play_button_draw_background()
play_button_draw_background_shadow_2()
play_button_draw_background_shadow_1()
play_button_draw_pause_symbol()
play_button_draw_previous_symbol()

... in play-button.c

The big list of variables in draw() should actually be #defines at the top of the file, thus simplifying quick changes of certain values.

Get rid of any cairo_surface_write_to_png().

Also delete all commented out code-lines which are left overs from testing/development.
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/custom-transport/+merge/29387
Your team ayatana-commits is subscribed to branch lp:indicator-sound.



References