ayatana-commits team mailing list archive
-
ayatana-commits team
-
Mailing list archive
-
Message #01833
Re: [Merge] lp:~cjcurran/indicator-sound/app-launching-finish into lp:indicator-sound
Review: Approve
* It would be nice to turn the ints at the top of
player-controler.vala into an enum so that we'd get some
type-safety from the variables.
* It seems like app_info and mpris_adaptor need to be initalized
in PlayerController()
* The player icon path is hardcoded (I think you mentioned that on
IRC)
* A padding of 10px on the title item seems like a lot to me. I'd
check that with design (unless it's already been given).
Otherwise it seems in good shape. Some little things, I think some will
be in other branches.
review approve
--
https://code.launchpad.net/~cjcurran/indicator-sound/app-launching-finish/+merge/29395
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
References