← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~cristiklein/notify-osd/multihead-bottompanel into lp:notify-osd/trunk

 

I have a few concerns about this patch partly because the conversation with Chow Loong Jin doesn't come to any actual conclusion.

 1, I'm concerned the patch breaks the following specification for spacing; https://wiki.ubuntu.com/NotifyOSD#Outside%20the%20bubble
 2, That in certain monitor configurations e.g. fullscreen application on the screen above the desktop screen and other similar corner cases this patch fails to correctly assign a screen for the notification to be on.
 3, There are commented out pieces of code left in the patch.

 
 
-- 
https://code.launchpad.net/~cristiklein/notify-osd/multihead-bottompanel/+merge/14983
Your team ayatana-commits is subscribed to branch lp:notify-osd/trunk.



References