ayatana-commits team mailing list archive

[David Barth <david.barth@xxxxxxxxxxxxx>]

Review: Needs Fixing
THe patch compiles and runs, but the rendering omits the label. Re-add the gtk_label_new call you suppressed.

On a more general note, you should check all arguments passed to your functions, in particular callbacks. If they are NULL or not of the right type, exit early to avoid de-referencing a pointer (and crashing).
-- 
https://code.launchpad.net/~cimi/indicator-messages/right-rounded-numbers/+merge/31262
Your team ayatana-commits is subscribed to branch lp:indicator-messages.