← Back to team overview

ayatana-commits team mailing list archive

Thread
Date

Re: [Merge] lp:~cjcurran/indicator-sound/mpris2-implementation into lp:indicator-sound

To: Conor Curran <conor.curran@xxxxxxxxxxxxx>
From: Ted Gould <ted@xxxxxxxx>
Date: Wed, 11 Aug 2010 19:19:45 -0000
In-reply-to: <20100811191121.27850.2027.launchpad@loganberry.canonical.com>
Reply-to: mp+32368@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve
The code seems okay.  I'm a bit worried that it seems we're choosing mpris 1 vs. 2 by a lookup table.  It seems we should be able to see which interface that the music player is exporting and choose the best one there.
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/mpris2-implementation/+merge/32368
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

References

[Merge] lp:~cjcurran/indicator-sound/mpris2-implementation into lp:indicator-sound
From: Conor Curran, 2010-08-11