← Back to team overview

ayatana-commits team mailing list archive

[Merge] lp:~bratsche/appmenu-gtk/do-rebuild-for-toplevels-only into lp:appmenu-gtk

 

Cody Russell has proposed merging lp:~bratsche/appmenu-gtk/do-rebuild-for-toplevels-only into lp:appmenu-gtk.

Requested reviews:
  Canonical Desktop Experience Team (canonical-dx-team)


I think this will improve startup time a little bit.
-- 
https://code.launchpad.net/~bratsche/appmenu-gtk/do-rebuild-for-toplevels-only/+merge/32532
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
=== modified file 'src/bridge.c'
--- src/bridge.c	2010-08-12 16:45:15 +0000
+++ src/bridge.c	2010-08-12 23:02:38 +0000
@@ -832,13 +832,16 @@
 static gboolean
 do_rebuild (RebuildData *data)
 {
-  rebuild_window_items (data->bridge,
-                        data->widget);
-
-  g_hash_table_remove (rebuild_ids, data->widget);
-  if (g_hash_table_size (rebuild_ids) == 0)
+  if (gtk_widget_is_toplevel (data->widget))
     {
-      g_hash_table_destroy (rebuild_ids);
+      rebuild_window_items (data->bridge,
+                            data->widget);
+
+      g_hash_table_remove (rebuild_ids, data->widget);
+      if (g_hash_table_size (rebuild_ids) == 0)
+        {
+          g_hash_table_destroy (rebuild_ids);
+        }
     }
 
   g_free (data);
@@ -868,7 +871,7 @@
   data->bridge = bridge;
   data->widget = toplevel;
 
-  id = g_timeout_add (500,
+  id = g_timeout_add (100,
                       (GSourceFunc)do_rebuild,
                       data);
 


Follow ups