ayatana-commits team mailing list archive

[David Barth <david.barth@xxxxxxxxxxxxx>]

Review: Needs Fixing
Cosmetic @line 146: delete and get it back from bzr history later? or add a comment explaining why it's commented out?

On the bridge class: For the future, turn into an interface implemented by either of the bridge classes, more than inheritance which is the root of all sins: Vala should support that hopefully ;)

Some more comments may help understand more quickly what the different functions do. Also, I don't see any tests for the new stuff.

Besides, test-indicator-sound.c in the tests directory fails to build.

Suggestion: record missing and broken tests as an extra bug and land that branch
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/mpris2-modifications/+merge/32898
Your team ayatana-commits is subscribed to branch lp:indicator-sound.