← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~ted/appmenu-gtk/ask-dbus into lp:appmenu-gtk

 

Review: Needs Fixing
Hmm, seems it will increase the chances the local menu will initially be shown (appmenuproxy set to NULL, and the online state being set to FALSE by default.

The default when the appmenu module is loaded should be to consider that the indicator will be present, and only show up the local menu if it cannot be detected.

I'd prefer to see a shorter async timeout to determine more quickly that the local menu should actually be shown.

But again, the case to optimize for is to connect to not show the local menu and export the menu on the bus as fast as possible.

People who don't want the ms penalty when using their desktop without indicator-appmenu should just de-install appmenu-gtk.
-- 
https://code.launchpad.net/~ted/appmenu-gtk/ask-dbus/+merge/32814
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.



References