← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~ted/dbusmenu/show-menu-on-activate into lp:dbusmenu

 

On Mon, 2010-08-23 at 10:34 +0000, David Barth wrote:
> Review: Needs Fixing
> Line 125: a bit uneasy to see priv dereferenced without being controlled first; is the GET_PRIVATE macro ensuring you will return immediately if passed some garbage/null pointer? Being a callback, it makes sense to be a bit picky.
> 
> Otherwise, good for me.

Fixed r161

-- 
https://code.launchpad.net/~ted/dbusmenu/show-menu-on-activate/+merge/33268
Your team ayatana-commits is subscribed to branch lp:dbusmenu.



References