← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~cjcurran/indicator-sound/remote-art-handling into lp:indicator-sound

 

Review: Needs Fixing
 * The temporary file needs to be built with mkstemp to create a random directory for the artwork.
 * It should be in the XDG temp directory instead of hardcoded to /tmp
 * You can use g_file_is_native() to determine whether it's local or not, just incase they're using something other than http://
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/remote-art-handling/+merge/34396
Your team ayatana-commits is subscribed to branch lp:indicator-sound.



References