ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Ted Gould has proposed merging lp:~ted/indicator-application/attention-icon into lp:indicator-application.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)


Small fix to the attention icons by making it so that we always update the icon.  Not perfect, but very harmless.
-- 
https://code.launchpad.net/~ted/indicator-application/attention-icon/+merge/35552
Your team ayatana-commits is subscribed to branch lp:indicator-application.

=== modified file 'src/application-service-appstore.c'
--- src/application-service-appstore.c	2010-09-08 00:22:05 +0000
+++ src/application-service-appstore.c	2010-09-15 16:20:59 +0000
@@ -602,7 +602,14 @@
 	}
 
 	/* Nothing needs to change, we're good */
-	if (app->visible_state == goal_state) {
+	if (app->visible_state == goal_state /* ) { */
+		&& goal_state == VISIBLE_STATE_HIDDEN) {
+		/* TODO: Uhg, this is a little wrong in that we're going to
+		   send an icon every time the status changes and the indicator
+		   is visible even though it might not be updating.  But, at
+		   this point we need a small patch that is harmless.  In the
+		   future we need to track which icon is shown and remove the
+		   duplicate message. */
 		return;
 	}