ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Review: Needs Information
A few concerns.

 * This patch adds several translatable strings.  So I don't think it can land for Maverick.
 * And this comment:
179	+  /* this is dangerous: it leaves the signal connected even if the dbusmenu
180	+     object is disposed, for example if the service quits
181	+  */
   We should just remove the signal handler on distruction instead of not having it, or delete the code entirely if it's not needed.
 * 

-- 
https://code.launchpad.net/~dbarth/indicator-me/entry-hint/+merge/35595
Your team ayatana-commits is subscribed to branch lp:indicator-me.