← Back to team overview

ayatana-commits team mailing list archive

[Merge] lp:~ted/dbusmenu/accel-ref into lp:dbusmenu

 

Ted Gould has proposed merging lp:~ted/dbusmenu/accel-ref into lp:dbusmenu.

Requested reviews:
  DBus Menu Team (dbusmenu-team)


This makes it so we ref the object that we need.  But, because there's a bug in i-appmenu we don't notice it.  More importantly, if this gets merged without the corresponding patch to appmenu we'll have a memory leak.
-- 
https://code.launchpad.net/~ted/dbusmenu/accel-ref/+merge/36590
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
=== modified file 'libdbusmenu-gtk/client.c'
--- libdbusmenu-gtk/client.c	2010-08-30 20:22:43 +0000
+++ libdbusmenu-gtk/client.c	2010-09-24 19:41:44 +0000
@@ -249,6 +249,7 @@
 	}
 
 	priv->agroup = agroup;
+	g_object_ref(priv->agroup);
 
 	return;
 }


Follow ups