ayatana-commits team mailing list archive

["Neil J. Patel" <neil.patel@xxxxxxxxxxxxx>]

Review: Approve
Looks good. One thing I'd tweak is that, when connecting to the notify signal, your only interested in the "parent" property, so instead of doing:

g_signal_connect (object, "notify", ....

You should do:

g_signal_connect (object, "notify::parent", ....

The former connects to all property change events, whereas the latter will only get you pinged when the one your interested in changes.

Marking as approved in any case, to avoid another review cycle. Nice work!
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/ambiance-fix/+merge/37149
Your team ayatana-commits is subscribed to branch lp:indicator-sound.