ayatana-commits team mailing list archive

[Conor Curran <conor.curran@xxxxxxxxxxxxx>]

Conor Curran has proposed merging lp:~cjcurran/indicator-sound/core-usage into lp:indicator-sound.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  #581173 indicator-sound-service eating CPU on second user login
  https://bugs.launchpad.net/bugs/581173
  #644981 indicator-sound takes over one CPU core if it can't access pulseaudio
  https://bugs.launchpad.net/bugs/644981


before, I was kicking off a new connection to pulse if the initial attempt failed even though the reconnect flag was passed.
Fixes many duplicate bugs been reported since early lucid. 

 
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/core-usage/+merge/37304
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

=== modified file 'src/pulse-manager.c'
--- src/pulse-manager.c	2010-09-14 17:21:02 +0000
+++ src/pulse-manager.c	2010-10-01 19:02:42 +0000
@@ -534,7 +534,6 @@
   case PA_CONTEXT_FAILED:
     g_warning("FAILED to retrieve context - Is PulseAudio Daemon running ?");
     pa_server_available = FALSE;
-    reconnect_to_pulse();
     break;
   case PA_CONTEXT_TERMINATED:
     /*			g_debug("context terminated");*/