ayatana-commits team mailing list archive

[Andrea Cimitan <andrea.cimitan@xxxxxxxxx>]

> I think you need to unref the font_desc at least, and the g_object_get as
> well, in the 2 functions get_current_font_name. Since you don't reuse the
> font_name, i'd merge the 2 functions and would do the g_object_unref on the
> font name once you're done with it.
> 
> Check also what happens if the font description is null (or font returns
> something weird), ie pango may not be happy being passed a null pointer.
> 
> I don't see any obvious divide by zero or other issues in the rest of the
> code.

Done.
What about PangoLayout inside the other functions?
Sorry I want to be precise ;)
-- 
https://code.launchpad.net/~cimi/indicator-messages/fixes-to-right-label-and-icon-dimension/+merge/37272
Your team ayatana-commits is subscribed to branch lp:indicator-messages.