← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~cjcurran/indicator-sound/reconnect-bug into lp:indicator-sound

 

Review: Needs Fixing
 * I think you need to do some sort of back off on the reconnection.  It seems like there might be cases where people have disabled Pulse, and it wouldn't be coming back anytime soon.
 * I'd only create the hashtable and context in the function, and just call that function at init().  That way there is less likely to be bugs in the future.
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/reconnect-bug/+merge/39987
Your team ayatana-commits is subscribed to branch lp:indicator-sound.



References