← Back to team overview

ayatana-commits team mailing list archive

Thread
Date

Re: [Merge] lp:~chrisccoulson/indicator-appmenu/ffox-fixes into lp:indicator-appmenu

To: David Barth <david.barth@xxxxxxxxxxxxx>
From: Ted Gould <ted@xxxxxxxx>
Date: Fri, 07 Jan 2011 04:52:15 -0000
In-reply-to: <20101215190626.14369.10779.launchpad@loganberry.canonical.com>
Reply-to: mp+43809@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Disapprove
I don't think this is correct.  The client subclass for the menu item should handle the about-to-show signal and pass that to the client.  indicator-appmenu shouldn't be talking to the client directly.
-- 
https://code.launchpad.net/~chrisccoulson/indicator-appmenu/ffox-fixes/+merge/43809
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.

References

[Merge] lp:~chrisccoulson/indicator-appmenu/ffox-fixes into lp:indicator-appmenu
From: David Barth, 2010-12-15