ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Review: Needs Fixing
conncetion_changed()

Should really check to see if status_proxy_cancel is NULL as well so that you don't allocate two of them.

status_proxy_cb()

You shouldn't cast the user_data to self before checking the error.  There is a few cases where the indicator could be deallocated before this function is called and therefore user_data would be a random pointer.


-- 
https://code.launchpad.net/~ken-vandine/indicator-me/gdbus/+merge/46178
Your team ayatana-commits is subscribed to branch lp:indicator-me.