ayatana-commits team mailing list archive

[Michael Terry <michael.terry@xxxxxxxxxxxxx>]

Michael Terry has proposed merging lp:~mterry/appmenu-gtk/fix-sensitive-actions into lp:appmenu-gtk/trunk.

Requested reviews:
  Canonical Desktop Experience Team (canonical-dx-team)

For more details, see:
https://code.launchpad.net/~mterry/appmenu-gtk/fix-sensitive-actions/+merge/47056

The GtkAction "notify" handler was looking up the visible status when notified about "sensitive" changes.  This is a patch to change that as well as add a stanza for watching when the action's "visible" state changes.

The sensitive/visible mixup MAY be responsible for the bug I've seen where every once in a blue moon, gedit's menu will be insensitive.  I've not been able to reproduce it, but I'm not the only one that's seen it.
-- 
https://code.launchpad.net/~mterry/appmenu-gtk/fix-sensitive-actions/+merge/47056
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk/trunk.

=== modified file 'src/bridge.c'
--- src/bridge.c	2011-01-14 17:25:07 +0000
+++ src/bridge.c	2011-01-21 16:41:22 +0000
@@ -682,6 +682,12 @@
     {
       dbusmenu_menuitem_property_set_bool (mi,
                                            DBUSMENU_MENUITEM_PROP_ENABLED,
+                                           gtk_action_is_sensitive (action));
+    }
+  else if (pspec->name == g_intern_static_string ("visible"))
+    {
+      dbusmenu_menuitem_property_set_bool (mi,
+                                           DBUSMENU_MENUITEM_PROP_VISIBLE,
                                            gtk_action_is_visible (action));
     }
   else if (pspec->name == g_intern_static_string ("active"))