ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Ted Gould has proposed merging lp:~ted/libindicate/mem-leak into lp:libindicate.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  #690668 libindicate, libdbusmenu, indicator-messages-service memleaks
  https://bugs.launchpad.net/bugs/690668

For more details, see:
https://code.launchpad.net/~ted/libindicate/mem-leak/+merge/47086

Memory leak patch from ~hyperair recorded on bug 690668
-- 
https://code.launchpad.net/~ted/libindicate/mem-leak/+merge/47086
Your team ayatana-commits is subscribed to branch lp:libindicate.

=== modified file 'libindicate/listener.c'
--- libindicate/listener.c	2011-01-13 22:43:05 +0000
+++ libindicate/listener.c	2011-01-21 19:56:48 +0000
@@ -1116,6 +1116,7 @@
 
 	if (error != NULL) {
 		g_warning("Listener display caused an error: %s", error->message);
+		g_error_free(error);
 	}
 	return;
 }
@@ -1145,6 +1146,7 @@
 
 	if (error != NULL) {
 		g_warning("Listener displayed caused an error: %s", error->message);
+		g_error_free(error);
 	}
 	return;
 }
@@ -1209,6 +1211,7 @@
 		g_warning("Really?  This can't happen.  WTF!  %s", g_variant_get_type_string(prop));
 	}
 
+	g_variant_unref(prop);
 	return;
 }