ayatana-commits team mailing list archive

Thread
Date

Re: [Merge] lp:~ted/dbusmenu/now-with-parsing into lp:dbusmenu

To: Ted Gould <ted@xxxxxxxx>
From: Mikkel Kamstrup Erlandsen <mikkel.kamstrup@xxxxxxxxx>
Date: Thu, 27 Jan 2011 08:46:55 -0000
In-reply-to: <20110126231248.24188.65712.launchpad@loganberry.canonical.com>
Reply-to: mp+47603@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
 review needsfixing

Just two minor things; dbusmenu_gtk_parse_menu_structure() needs
documentation. In order to help would/be consumers with debugging you
should also add a g_return_val_if_fail(GTK_IS_MENU_ITEM(widget) ||
GTK_IS_MENU_SHELL (widget),NULL).

-- 
https://code.launchpad.net/~ted/dbusmenu/now-with-parsing/+merge/47603
Your team ayatana-commits is subscribed to branch lp:dbusmenu.

Follow ups

Re: [Merge] lp:~ted/dbusmenu/now-with-parsing into lp:dbusmenu
From: Ted Gould, 2011-01-27

References

[Merge] lp:~ted/dbusmenu/now-with-parsing into lp:dbusmenu
From: Ted Gould, 2011-01-26