ayatana-commits team mailing list archive

[Mikkel Kamstrup Erlandsen <mikkel.kamstrup@xxxxxxxxx>]

Review: Needs Fixing
The function prototypes DbusmenuClientTypeHandler and DbusmenuClientTypeDestroyHandler needs documentation.

Can we avoid double namespacing on these two functions?:

dbusmenu_gtk_serializable_menu_item_build_dbusmenu_menuitem()
dbusmenu_gtk_serializable_menu_item_set_dbusmenu_menuitem()

Becomes:

dbusmenu_gtk_serializable_menu_item_build_menuitem()
dbusmenu_gtk_serializable_menu_item_set_menuitem()

Can you add some section docs describing what the purpose of DbusmenuGtkSerializableMenuItem is, and how to use it? After reviewing this code I am still not entirely sure what it's supposed to do :-)
-- 
https://code.launchpad.net/~ted/dbusmenu/serializable-menuitem/+merge/47604
Your team ayatana-commits is subscribed to branch lp:dbusmenu.