ayatana-commits team mailing list archive

[Michael Terry <michael.terry@xxxxxxxxxxxxx>]

Michael Terry has proposed merging lp:~mterry/appmenu-gtk/blacklist-eclipse into lp:appmenu-gtk.

Requested reviews:
  Canonical Desktop Experience Team (canonical-dx-team)

For more details, see:
https://code.launchpad.net/~mterry/appmenu-gtk/blacklist-eclipse/+merge/49393

Eclipse doesn't yet work with appmenu.  This historically was fixed in bug 618587 by having the eclipse wrapper export UBUNTU_MENUPROXY=0.  However, this had the side effect of disabling appmenu support for all applications run from eclipse.  This wasn't entirely undesired, because all Java SWT apps didn't work with appmenu.

Now that SWT apps have been fixed (as part of bug 618587), eclipse shouldn't be so ham-fisted.  So I plan to remove the export from its wrapper, but it still needs to be blacklisted.

Hence this merge, with its much more targeted blacklist.
-- 
https://code.launchpad.net/~mterry/appmenu-gtk/blacklist-eclipse/+merge/49393
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.

=== modified file 'src/bridge.c'
--- src/bridge.c	2011-02-07 19:14:08 +0000
+++ src/bridge.c	2011-02-11 14:03:57 +0000
@@ -816,6 +816,7 @@
       || (g_strcmp0 (prg, "midori") == 0)
       || (g_strcmp0 (prg, "firefox-bin") == 0)
       || (g_strcmp0 (prg, "thunderbird-bin") == 0)
+      || (g_strcmp0 (prg, "Eclipse") == 0)
       || (g_strcmp0 (prg, "gnome-panel") == 0))
     {
       return TRUE;