ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Review: Needs Fixing
On Tue, 2011-02-15 at 01:04 +0000, Luke Yelavich wrote:
> @@ -621,6 +623,11 @@
>  	if (ltime == NULL) {
>  		g_debug("Error getting local time");
>  		gtk_label_set_label(self->priv->label, _("Error getting time"));
> +		g_signal_emit(G_OBJECT(self),
> +		              INDICATOR_OBJECT_SIGNAL_ACCESSIBLE_DESC_UPDATE_ID,
> +		              0,
> +		              (IndicatorObjectEntry *)indicator_object_get_entries(INDICATOR_OBJECT(self))->data,
> +		              TRUE);
>  		return NULL;
>  	}
>  
> @@ -642,6 +649,12 @@
>  		self->priv->idle_measure = g_idle_add(idle_measure, io);
>  	}
>  
> +	g_signal_emit(G_OBJECT(self),
> +	              INDICATOR_OBJECT_SIGNAL_ACCESSIBLE_DESC_UPDATE_ID,
> +	              0,
> +	              (IndicatorObjectEntry *)indicator_object_get_entries(INDICATOR_OBJECT(self))->data,
> +	              TRUE);
> +
>  	return ltime;
>  }

indicator_object_get_entires() returns a new GList of the entires
(though for this one it is only one).  So the list needs to be free'd or
there will be a memory leak.

  review needsfixing

-- 
https://code.launchpad.net/~themuso/indicator-datetime/accessible-desc/+merge/49747
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.