ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Review: Needs Fixing
On Thu, 2011-02-10 at 23:32 +0000, Michael Terry wrote:
> +  if (icon_name != NULL) {
>      dbusmenu_menuitem_property_set (menuitem,
>                                      DBUSMENU_MENUITEM_PROP_ICON_NAME,
>                                      icon_name);
> -  } else {
> +  }
> +  else if (pixbuf != NULL) {
> +    dbusmenu_menuitem_property_set_image (menuitem,
> +                                          DBUSMENU_MENUITEM_PROP_ICON_DATA,
> +                                          pixbuf);
> +  }
> +  else {
>      dbusmenu_menuitem_property_remove (menuitem,
>                                         DBUSMENU_MENUITEM_PROP_ICON_NAME);
> +    dbusmenu_menuitem_property_remove (menuitem,
> +                                       DBUSMENU_MENUITEM_PROP_ICON_DATA);
> +  }

I think in this statement it should remove the opposite property so that
we know only one is set in the end.

  review needsfixing

-- 
https://code.launchpad.net/~mterry/dbusmenu/handle-icons-better/+merge/49321
Your team ayatana-commits is subscribed to branch lp:dbusmenu.