ayatana-commits team mailing list archive

[Mathieu Trudel-Lapierre <mathieu.tl@xxxxxxxxx>]

This would help us avoid having "enabled", "visible", "label" properties as NULL where possible.

The goal here (though I might well have misread the code.. was operating with a bad headache), is to fix these labels at least for GtkAction menuitem: looks to me like the action_notify_cb() function is being called after widget_notify_cb() (since it's connected after other signals). In the case of handling a GtkAction item such as for gnome-bluetooth's menus, calls to gtk_widget_get_sensitive(), gtk_menu_item_get_label(), etc will definitely return undef/NULL because they would fail to assert the GtkAction object as a GtkWidget/GtkMenuItem.

Please don't hesitate to just mark this Rejected if it doesn't make sense; I wasn't able to reproduce the crasher before this patch; and I'm still unable to (though it doesn't seem to break anything).
-- 
https://code.launchpad.net/~mathieu-tl/dbusmenu/widget_notify_properties_access/+merge/50974
Your team ayatana-commits is subscribed to branch lp:dbusmenu.