ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Review: Approve
A few comments:
 
* Please don't comment out code.  Either delete or fix, we have version control to find old code if we need it.

* Added a check to see if we're the parent to delete or else we could end up with really weird unparenting from non-parents.

* get_parent() needs a transfer annotation

* please try to keep it to one feature/fix per branch as it makes it easier to review and understand the impact of the change.

* new functions need to be added to "sections.txt" for the documentation.

I fixed these and merged the whole thing in.  Thanks for the investigation and fixing these!
-- 
https://code.launchpad.net/~chrisccoulson/dbusmenu/more-memory-fixes/+merge/51152
Your team ayatana-commits is subscribed to branch lp:dbusmenu.