ayatana-commits team mailing list archive

[Michael Terry <michael.terry@xxxxxxxxxxxxx>]

Michael Terry has proposed merging lp:~mterry/indicator-application/fix-crash-724767 into lp:indicator-application.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  #724767 indicator-application-service crashed with SIGSEGV in g_variant_builder_add_value()
  https://bugs.launchpad.net/bugs/724767

For more details, see:
https://code.launchpad.net/~mterry/indicator-application/fix-crash-724767/+merge/51292
-- 
https://code.launchpad.net/~mterry/indicator-application/fix-crash-724767/+merge/51292
Your team ayatana-commits is subscribed to branch lp:indicator-application.

=== modified file 'src/application-service-appstore.c'
--- src/application-service-appstore.c	2011-02-25 04:02:15 +0000
+++ src/application-service-appstore.c	2011-02-25 13:49:05 +0000
@@ -1238,9 +1238,10 @@
 			}
 
 			g_variant_builder_add (&builder, "(sisossss)", app->icon,
-								   position++, app->dbus_name, app->menu,
-								   app->icon_theme_path, app->label,
-								   app->guide, app->icon_desc);
+			                       position++, app->dbus_name, app->menu,
+			                       app->icon_theme_path, app->label,
+			                       app->guide,
+			                       (app->icon_desc != NULL) ? app->icon_desc : "");
 		}
 
 		out = g_variant_builder_end(&builder);