← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~mterry/indicator-datetime/clock-prefs into lp:indicator-datetime

 

Review: Needs Fixing
The 2nd and 3rd call-by-ref parameter of split_settings_location() are never g_free()ed. I'm not sure if the recepients of these take care of that. So this might be a potential mem-leak, since in split_settings_location() there are g_strdup()ed.

There's a certain mem-lean in libmap/test-timezone.c. There's no tz_info_free() corresponding to info = tz_info_from_location (loc); in the for-loop.
-- 
https://code.launchpad.net/~mterry/indicator-datetime/clock-prefs/+merge/51013
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.



References