ayatana-commits team mailing list archive

[Karl Lattimer <karl@xxxxxxxxxx>]

> On Tue, 2011-03-08 at 16:09 +0000, Karl Lattimer wrote:
> > +     gchar *time_format_str = g_settings_get_string(conf,
> SETTINGS_TIME_FORMAT_S);
> > +     gint apt_output;
> 
> I think that you should be able to use priv->time_mode instead of
> apt_output here.

priv->time_mode is in indicator-datetime.c we don't have a priv in datetime-service.c so I had to duplicate a little bit here.


> All of the strings being passed to strftime need a _() around them so
> that they go through gettext.

I thought that as they're all defined with N_() around them in settings-shared.h that they wouldn't however, I've added the _() and am resubmitting the branch now. 
-- 
https://code.launchpad.net/~karl-qdh/indicator-datetime/fixappointmentformat/+merge/52574
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.