← Back to team overview

ayatana-commits team mailing list archive

[Merge] lp:~karl-qdh/indicator-datetime/nopwdprompt into lp:indicator-datetime

 

Karl Lattimer has proposed merging lp:~karl-qdh/indicator-datetime/nopwdprompt into lp:indicator-datetime.

Requested reviews:
  Ted Gould (ted)

For more details, see:
https://code.launchpad.net/~karl-qdh/indicator-datetime/nopwdprompt/+merge/53846

Removes prompting for password if no stored credential exists.
-- 
https://code.launchpad.net/~karl-qdh/indicator-datetime/nopwdprompt/+merge/53846
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
=== modified file 'src/datetime-service.c'
--- src/datetime-service.c	2011-03-16 21:47:51 +0000
+++ src/datetime-service.c	2011-03-17 15:55:46 +0000
@@ -469,7 +469,6 @@
            const gchar *key, 
            gpointer user_data)
 {
-	gboolean remember; // TODO: Is this useful?  Should we be storing it somewhere?
 	ESource *source = e_cal_get_source (ecal);
 	gchar *auth_domain = e_source_get_duped_property (source, "auth-domain");
 
@@ -479,16 +478,6 @@
 	
 	gchar *password = e_passwords_get_password (component_name, key);
 	
-	if (password == NULL) {
-		password = e_passwords_ask_password (
-			_("Enter password"),
-			component_name, key, prompt,
-			E_PASSWORDS_REMEMBER_FOREVER |
-			E_PASSWORDS_SECRET |
-			E_PASSWORDS_ONLINE,
-			&remember, NULL);
-	}
-	
 	g_free (auth_domain);
 
 	return password;


Follow ups