ayatana-commits team mailing list archive

[Ken VanDine <ken.vandine@xxxxxxxxxxxxx>]

Ken VanDine has proposed merging lp:~ken-vandine/indicator-me/lp_754524 into lp:indicator-me.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)
Related bugs:
  Bug #754524 in The Me Menu: "unity-panel-service crashed with SIGSEGV in g_variant_new_va()"
  https://bugs.launchpad.net/indicator-me/+bug/754524

For more details, see:
https://code.launchpad.net/~ken-vandine/indicator-me/lp_754524/+merge/57713

Pass the username as a g_variant on the UserChanged signal (LP: #754524)

-- 
https://code.launchpad.net/~ken-vandine/indicator-me/lp_754524/+merge/57713
Your team ayatana-commits is subscribed to branch lp:indicator-me.

=== modified file 'src/indicator-me.c'
--- src/indicator-me.c	2011-04-04 16:47:54 +0000
+++ src/indicator-me.c	2011-04-14 15:46:27 +0000
@@ -179,7 +179,7 @@
 username_cb (GObject * object, GAsyncResult * res, gpointer user_data)
 {
 	GError * error = NULL;
-	gchar * username;
+	gchar * username = NULL;
 	GVariant * result;
 
 	IndicatorMe * self = INDICATOR_ME (user_data);

=== modified file 'src/me-service-dbus.c'
--- src/me-service-dbus.c	2011-01-13 20:37:08 +0000
+++ src/me-service-dbus.c	2011-04-14 15:46:27 +0000
@@ -310,11 +310,11 @@
                                        INDICATOR_ME_SERVICE_DBUS_OBJECT,
                                        INDICATOR_ME_SERVICE_DBUS_INTERFACE,
                                        "UserChanged",
-                                       NULL,
+                                       g_variant_new("(s)", username),
                                        &error);
 
 	if (error != NULL) {
-		g_error("Unable to send UserChanged signal: %s", error->message);
+		g_warning("Unable to send UserChanged signal: %s", error->message);
 		g_error_free(error);
 		return;
 	}