ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

It seems like ref_default does transfer a reference to the caller.  So
we shouldn't be using (none).  Does this have a bug with it?

On Mon, 2011-04-18 at 14:26 +0000, Ken VanDine wrote:
> Ken VanDine has proposed merging lp:~ken-vandine/libindicate/server_add_annotations into lp:libindicate.
> 
> Requested reviews:
>   Indicator Applet Developers (indicator-applet-developers)
> 
> For more details, see:
> https://code.launchpad.net/~ken-vandine/libindicate/server_add_annotations/+merge/58133
> 
> added annotations for indicate_server_ref_default
> differences between files attachment (review-diff.txt)
> === modified file 'libindicate/server.c'
> --- libindicate/server.c	2011-03-30 13:35:14 +0000
> +++ libindicate/server.c	2011-04-18 14:26:31 +0000
> @@ -1458,7 +1458,7 @@
>  	use this function to create a #IndicateServer as it ensure that there
>  	is only one per application.
>  
> -	Return value: A reference to the default #IndicateServer instance.
> +	Return value: (transfer none): A reference to the default #IndicateServer instance.
>  */
>  IndicateServer *
>  indicate_server_ref_default (void)
> 
> === modified file 'libindicate/server.h'
> --- libindicate/server.h	2011-01-12 18:29:40 +0000
> +++ libindicate/server.h	2011-04-18 14:26:31 +0000
> @@ -233,6 +233,17 @@
>  void indicate_server_add_indicator (IndicateServer * server, IndicateIndicator * indicator);
>  void indicate_server_remove_indicator (IndicateServer * server, IndicateIndicator * indicator);
>  
> +/**
> + * indicate_server_ref_default:
> +
> + * This function will return a reference to the default #IndicateServer
> + * reference if there is one, or it will create one if one had not
> + * previously been created.  It is recommended that all applications
> + * use this function to create a #IndicateServer as it ensure that there
> + * is only one per application.
> + * 
> + * Return value: (transfer none): A reference to the default #IndicateServer instance.
> +*/
>  IndicateServer * indicate_server_ref_default (void);
>  void indicate_server_set_default (IndicateServer * server);
>  
> 



-- 
https://code.launchpad.net/~ken-vandine/libindicate/server_add_annotations/+merge/58133
Your team ayatana-commits is subscribed to branch lp:libindicate.