← Back to team overview

ayatana-commits team mailing list archive

[Merge] lp:~njpatel/indicator-session/send-real-pointers into lp:indicator-session

 

Neil J. Patel has proposed merging lp:~njpatel/indicator-session/send-real-pointers into lp:indicator-session.

Requested reviews:
  Conor Curran (cjcurran)

For more details, see:
https://code.launchpad.net/~njpatel/indicator-session/send-real-pointers/+merge/68669

This fixes the issue with entries not working correctly in the unity panel (panel-service uses the pointer info and therefore it means you need to always send the actual address of the entry).
-- 
https://code.launchpad.net/~njpatel/indicator-session/send-real-pointers/+merge/68669
Your team ayatana-commits is subscribed to branch lp:indicator-session.
=== modified file 'src/indicator-session.c'
--- src/indicator-session.c	2011-07-14 16:20:38 +0000
+++ src/indicator-session.c	2011-07-21 12:23:26 +0000
@@ -449,17 +449,15 @@
   //Otherwise
   self->show_users_entry = update;
 
-  IndicatorObjectEntry user_entry = self->users;
-  
   if (self->show_users_entry == TRUE){
     g_signal_emit_by_name ((gpointer)self,
                            "entry-added",
-                           &user_entry);   
+                           &self->users);   
   }
   else{
     g_signal_emit_by_name ((gpointer)self,
                            "entry-removed",
-                           &user_entry);       
+                           &self->users);       
   }
 }
 
@@ -489,18 +487,16 @@
     
     //Otherwise
     self->show_users_entry = update;
-
-    IndicatorObjectEntry user_entry = self->users;
     
     if (self->show_users_entry == TRUE){
       g_signal_emit_by_name ((gpointer)self,
                              "entry-added",
-                             &user_entry);
+                             &self->users);
     }   
     else{
       g_signal_emit_by_name ((gpointer)self,
                              "entry-removed",
-                             &user_entry);       
+                             &self->users);       
     }
   }
 }


Follow ups