← Back to team overview

ayatana-commits team mailing list archive

Re: [Merge] lp:~cjcurran/indicator-session/device-menu-reorg into lp:indicator-session

 

Review: Approve
I think in apt_transaction_receive_signal you need to g_variant_unref the value variable after looking at it.

The AppTransaction object should get it's proxy async.  Shouldn't take *that* long, but it should.

+#include <libdbusmenu-gtk3/menuitem.h> Needs to be in a #ifdef to see if it's GTK3 or 2 and drop the "gtk3" part of the include on 2.

_("System Settings...") should have a proper ellipsis (along with others)

-- 
https://code.launchpad.net/~cjcurran/indicator-session/device-menu-reorg/+merge/68737
Your team ayatana-commits is subscribed to branch lp:indicator-session.


References