ayatana-commits team mailing list archive

["Neil J. Patel" <neil.patel@xxxxxxxxxxxxx>]

Review: Needs Fixing
- Your leaking all the contents of the lists you add to the hash tables as g_list_free isn't going to do anything to the data the list points too.  I think you need to initially do something like iterate the hash table, which then calls g_list_foreach on every value with g_free.

- gchar* random_scanner_name = 	g_strdup_printf("%p--scanner", self);
  g_hash_table_insert (self->scanners_present,
                       g_strdup(random_scanner_name),
                       g_strdup("Scanner")); 
  g_free (random_scanner_name);

just don't free random_scanner_name and send it in without g_strdup?


Apart from that, nothing jumps out at me. However, I can't mark as approved as it crashes every time on my system with the same backtrace as we spoke about (when trying to register the DBus Service). I tried lp:indicator-session and it runs fine, so it's definitely something in this branch :/

I'll have another look at the diff tomorrow morning, but if your around it would be good to maybe go through on Mumble or something to see if there's something we've missed?
-- 
https://code.launchpad.net/~cjcurran/indicator-session/udev-beginnings/+merge/70534
Your team ayatana-commits is subscribed to branch lp:indicator-session.