ayatana-commits team mailing list archive

[Michael Terry <michael.terry@xxxxxxxxxxxxx>]

Review: Needs Fixing
To make the list button look right, you should also set the "inline-toolbar" style class for the toolbar.  See gnome-control-center panels for example .ui xml for it.  I don't know whether glade exposes it or not.

- <!-- column-name Visible Name -->
+ <!-- column-name Visible -->

Why this change?

- <object class="GtkVBox" id="vbox4">
+ <object class="GtkBox" id="box9">

This is missing its vertical orientation setting.

- GtkWidget * hbox = gtk_hbox_new(FALSE, 4);
+ GtkWidget * box = gtk_box_new(FALSE, 4);

FALSE here should be GTK_ORIENTATION_HORIZONTAL.  Same for similar changes.
-- 
https://code.launchpad.net/~jbicha/indicator-datetime/replace-deprecated-ui/+merge/72997
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.