ayatana-commits team mailing list archive

[Andrea Cimitan <andrea.cimitan@xxxxxxxxxxxxx>]

Review: Needs Information

It depends... if error is != NULL it enters the first if but not the second, so accounts_list is set to NULL and not free'd. Now, it could be that if error is != NULL then accounts_list is NULL and it does not need to be free'd, so your code is not leaking.
However, I'm not sure of that (that accounts_list is NULL and thus does not need to be free'd if error is != NULL), so in my ignorance I'd put the code as I wrote before, adding

if (accounts_list)
  g_slist_free (accounts_list);

before setting it to NULL in the first if.

If you're sure of my concern, go ahead, otherwise we might need to look at gconf code and see which GSList we can receive from gconf_client_get_list when error is not NULL.
-- 
https://code.launchpad.net/~jjardon/indicator-datetime/fix-836017/+merge/77932
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.