← Back to team overview

ayatana-commits team mailing list archive

Thread
Date

Re: [Merge] lp:~ted/indicator-session/lp864085 into lp:indicator-session

To: Ted Gould <ted@xxxxxxxx>
From: Michal Hruby <michal.mhr@xxxxxxxxx>
Date: Mon, 10 Oct 2011 15:16:38 -0000
In-reply-to: <20111008195526.6610.15414.launchpad@ackee.canonical.com>
Reply-to: mp+78733@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Putting function calls into g_return_* macros is quite dangerous, cause you can easily compile those away (using G_DISABLE_CHECKS). Please use a temp variable for what you're doing.
-- 
https://code.launchpad.net/~ted/indicator-session/lp864085/+merge/78733
Your team ayatana-commits is subscribed to branch lp:indicator-session.

References

[Merge] lp:~ted/indicator-session/lp864085 into lp:indicator-session
From: Ted Gould, 2011-10-08