ayatana-commits team mailing list archive

[Ted Gould <ted@xxxxxxxx>]

Ted Gould has proposed merging lp:~ted/indicator-datetime/geoclue-fix into lp:indicator-datetime.

Requested reviews:
  Indicator Applet Developers (indicator-applet-developers)

For more details, see:
https://code.launchpad.net/~ted/indicator-datetime/geoclue-fix/+merge/80159

Fixing the check for the client so the GeoClue feature actually works.  Eh, no comment on why this was missed for so long :-/
-- 
https://code.launchpad.net/~ted/indicator-datetime/geoclue-fix/+merge/80159
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.

=== modified file 'src/datetime-service.c'
--- src/datetime-service.c	2011-10-13 04:30:40 +0000
+++ src/datetime-service.c	2011-10-23 21:59:25 +0000
@@ -1404,7 +1404,12 @@
 
 	geo_master = client;
 
-	if (geo_master != NULL) {
+	if (error != NULL) {
+		g_warning("Unable to get a GeoClue client!  '%s'  Geolocation based timezone support will not be available.", error->message);
+		return;
+	}
+
+	if (geo_master == NULL) {
 		g_warning(_("Unable to get a GeoClue client!  Geolocation based timezone support will not be available."));
 		return;
 	}