ayatana-commits team mailing list archive
-
ayatana-commits team
-
Mailing list archive
-
Message #04048
Re: [Merge] lp:~jconti/indicator-applet/gnome3 into lp:indicator-applet
Review: Approve
Great, thanks for the work on this. A few comments:
* Please don't change the version number in configure.ac, it really confuses things if there are multiple version numbers in "the wild" so it's better just to have one place define it. I'll fix this on merge, no worries there.
* Love that you changed the strings to #defines. I think that's a wonderful thing :-)
Thanks again for your work.
--
https://code.launchpad.net/~jconti/indicator-applet/gnome3/+merge/80877
Your team ayatana-commits is subscribed to branch lp:indicator-applet.
References