ayatana-commits team mailing list archive

[Gustavo Pichorim Boiko <gustavo.boiko@xxxxxxxxxxxxx>]

> My suggestion is that instead of removing the old constructor you leave it
> there, i.e. you end up with
> 
> Server::Server(QObject* parent)
> Server::Server(QObject* parent, const QString &path)
> 
> to avoid having to duplicate the code of the constructor you can make them
> both call a private init(QObject *, const QString &) function
> 
> This way you don't break binary compatibility ( since adding a friend is fine
> as stated in
> http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B )
> which is a nice thing to have in my opinion

Indeed, this is a better option. I have implemented the suggestions already.

Thanks
-- 
https://code.launchpad.net/~boiko/libindicate-qt/libindicate-multiple_servers/+merge/121916
Your team ayatana-commits is subscribed to branch lp:libindicate-qt.